Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually finish flipping the Y axis #275

Merged
merged 17 commits into from
May 29, 2019
Merged

Actually finish flipping the Y axis #275

merged 17 commits into from
May 29, 2019

Conversation

AstraLuma
Copy link
Member

So that easy little y-flip PR I did left a bunch of stuff broken.

Fix that.

@AstraLuma AstraLuma requested a review from a team as a code owner May 19, 2019 19:58
AstraLuma
AstraLuma commented May 20, 2019
View reviewed changes
Copy link
Member Author

@AstraLuma AstraLuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a hypothesis test for round-tripping conversions?

Like convert viewport->frame->viewport (and vice versa) should produce the same-ish vector.

tests/test_camera.py
assert cam.position == Vector(0, 0)
assert cam.translate_to_viewport(Vector(0, 0)) == Vector(400, 300)
assert cam.translate_to_viewport(Vector(100, 100)) == Vector(500, 200)
assert cam.translate_to_viewport(Vector(-150, -500)) == Vector(250, 800)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to parameterize these tests? It seems like we have a lot of tests that are the same basic format?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that when I find a spare moment.

@AstraLuma AstraLuma changed the title WIP Actually finish flipping the Y axis Actually finish flipping the Y axis May 24, 2019
@AstraLuma AstraLuma mentioned this pull request May 25, 2019
Open
@pathunstrom
Copy link
Collaborator

This looks good, rerunning the failed tests, will merge when it's done.

@nbraud
Copy link
Contributor

nbraud commented May 29, 2019

@pathunstrom FYI, you can always invoke bors r+ and it will happily wait for tests to be done (or timeout after 3h) before merging. It also does the test on a merge with the target branch, so manually merging master into this wasn't necessary. :3

bors r=pathunstrom

bors bot added a commit that referenced this pull request May 29, 2019
@bors @AstraLuma @pathunstrom
Merge #275
914ecfd 
275: Actually finish flipping the Y axis r=pathunstrom a=astronouth7303

So that easy little y-flip PR I did left a bunch of stuff broken.

Fix that.

Co-authored-by: Jamie Bliss <jamie@ivyleav.es>
Co-authored-by: Piper Thunstrom <pathunstrom@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 29, 2019

Build succeeded

  • docs
  • Linux python:3.6-slim
  • Linux python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows python:3.6-windowsservercore-1809
  • Windows python:3.7-windowsservercore-1809

@bors bors bot merged commit da47672 into ppb:master May 29, 2019
@pathunstrom
Copy link
Collaborator

I mean, I intentionally wanted to make sure it was working before I walked away from it.

@nbraud
Copy link
Contributor

nbraud commented May 29, 2019

'k, then I misunderstood the comment (but I did check the CI log before kicking off the merge)

@pathunstrom
Copy link
Collaborator

Then all's good. Just explaining my thought process, no worries.

@AstraLuma AstraLuma deleted the camera-y-flip branch July 11, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathunstrom pathunstrom pathunstrom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AstraLuma @pathunstrom @nbraud